Skip to content

Quadlet sugar#694

Open
angelcerveraroldan wants to merge 3 commits intocoreos:mainfrom
angelcerveraroldan:quadlet-sugar
Open

Quadlet sugar#694
angelcerveraroldan wants to merge 3 commits intocoreos:mainfrom
angelcerveraroldan:quadlet-sugar

Conversation

@angelcerveraroldan
Copy link
Copy Markdown
Member

@angelcerveraroldan angelcerveraroldan commented Mar 20, 2026 •
edited
Loading

Basic sugar for quadlets. Allows for the following syntax:

variant: fcos
version: 1.8.0-experimental
systemd:
  quadlets:
    - name: sleepy-disk.container
      rootful: true
      contents_local: containers/sleepy.container
    - name: sleepy-infinity.container
      rootful: true
      contents: |
        [Unit]
        Description=A sleepy container
        [Container]
        ContainerName=sleepy-pod-inf
        Image=quay.io/fedora/fedora
        Exec=sleep infinity
        [Install]
        WantedBy=multi-user.target

I still need to add examples for the docs, and to run more tests.

Docs about quadlets can be found here.

gemini-code-assist[bot]
gemini-code-assist bot reviewed Mar 20, 2026
View reviewed changes
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces basic support for Podman quadlets, allowing their definition within the systemd configuration. The changes include extending the Systemd struct with a Quadlets field, defining a new Quadlet struct, and implementing the translation logic to convert quadlets into Ignition files or symlinks. Comprehensive validation has been added to ensure correct quadlet naming conventions and content sources. The new functionality is well-covered by unit tests, demonstrating handling of basic quadlets, template instances, local content, and error conditions. The implementation is clean and robust for the features introduced.

@angelcerveraroldan angelcerveraroldan force-pushed the quadlet-sugar branch 11 times, most recently from af44334 to 4f6f4ae Compare March 25, 2026 18:34
@angelcerveraroldan angelcerveraroldan marked this pull request as ready for review March 25, 2026 18:36
@angelcerveraroldan angelcerveraroldan added the sugar Issue related to config sugar label Mar 26, 2026
@angelcerveraroldan angelcerveraroldan force-pushed the quadlet-sugar branch 2 times, most recently from 8cf12e2 to 339567f Compare March 27, 2026 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

sugar Issue related to config sugar

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@angelcerveraroldan